Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

man pages: switch to https://example.com URLs #5969

Closed
wants to merge 2 commits into from
Closed

Conversation

@bagder
Copy link
Member

@bagder bagder commented Sep 16, 2020

Since HTTPS is "the new normal", this update changes a lot of man page
examples to use https://example.com instead of the previous "http://..."

Since HTTPS is "the new normal", this update changes a lot of man page
examples to use https://example.com instead of the previous "http://..."
@emilengler
Copy link
Contributor

@emilengler emilengler commented Sep 17, 2020

A no vote from me. TLS support is not compiled by default, only if such a library is found on the system. Also it can lead to many issues like invalid certificates...

Don't get me wrong and think I am not a fan of HTTPS, I just tjink it's too much overkill for an example. Also it would more or less add an external dependeny required for it

@bagder
Copy link
Member Author

@bagder bagder commented Sep 17, 2020

With "the new normal" I mean that HTTPS is the most commonly used protocol for users to use with curl, and it is by far the most commonly used protocol in browsers and when showing links in general today (in print, on a site, in an email etc).

There's virtually no users around anymore who build curl with HTTP support but without HTTPS. I don't see how it is "overkill" for an example since it just changes the URL string with an added s. I want the URLs to feel and look like "normal" URLs. I think today, using https:// instead of http:// is a way to do that.

@emilengler
Copy link
Contributor

@emilengler emilengler commented Sep 17, 2020

I see the overkill in too many things not always handled there like certificate validation.
Also to the point that "nobody" is building curl without HTTPS, then we can also make a TLS a hard dependency

@bagder
Copy link
Member Author

@bagder bagder commented Sep 17, 2020

I see the overkill in too many things not always handled there like certificate validation.

The examples in the man pages are only very small snippets showing how to use a particular option, they're not complete stand-alone apps. Besides, certificate validation is enabled by default and for most users it should work exactly as intended without any additional options.

Also to the point that "nobody" is building curl without HTTPS, then we can also make a TLS a hard dependency

Exactly how would this make anything better for anyone? It also seems unrelated to this change...

@emilengler
Copy link
Contributor

@emilengler emilengler commented Sep 17, 2020

IMO this discussion is pointless as well as this PR. I don't see any notable improvement. Also it doesn't really matter if our examples use http:// or https:// as anyone with a decent level of intelligence can imagine that they are related somehow.

@emilengler
Copy link
Contributor

@emilengler emilengler commented Sep 17, 2020

I will give a ~0 on this now.

@bagder bagder closed this in 83cc966 Sep 17, 2020
@bagder bagder deleted the bagder/manpages-https branch Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.