ftp: avoid risk of reading uninitialized integers

[bagder]

If the received PASV response doesn't match the expected pattern, we
could end up reading uninitialized integers for IP address and port
number.

Issue pointed out by muse.dev

[emilengler]

Can't you use this initializer?
x[4] = { 0 }; to init everything?

[emilengler]

Sorry I meant int x[4] = { 0 } ;)

See: https://stackoverflow.com/questions/201101/how-to-initialize-all-members-of-an-array-to-the-same-value

[bagder]

That's a C99 feature that didn't exist in C89.

[emilengler]

That's a C99 feature that didn't exist in C89.

Wow that fact just destroyed my universe. Anyway then go ahead!

[emilengler]

Maybe write 0u instead of 0 though

[bagder]

I could, but personally I often sort of "react" a little on the extra letter like that and I prefer to go without it if I can. For this, I don't see the need to emphasize in the constant that it is an unsigned value. zero is still zero.

[jay]

That's a C99 feature that didn't exist in C89.

? No it's not and we use {0} elsewhere. It's fine either way though.

[bagder]

hm okay, thanks, then I stand corrected!