New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Remove 9 year old comment in memdebug.c #5973
refactor: Remove 9 year old comment in memdebug.c #5973
Conversation
The comment described a way how an ancient libcurl version handled memory. 9 years later this has no value to be in there. If people need to know about it they can have a look at VCS logs. Closes curl#5973
16693c6
to
93bd41c
Compare
I think you should consider removing the entire memfill functionality if you remove the backstory/docs for it. That custom memory fill thing has lost its purpose. valgrind and ASAN are superior tools to catch memory issues. |
I will try to work on this until Saturday. I am currently a bit busy |
The used to be away how an ancient libcurl version handled memory. 9 years later this has no value to be in there. If people need to know about it they can have a look at VCS logs. Closes curl#5973
93bd41c
to
bcc3fe9
Compare
Found some time actually! This is ready for merge I think |
You need to remove the use of those macros too:
|
Sure... but my cc haven't reported a single error on that patch |
Then you must've forgot to build it debug-enabled - as you can see in the CI... |
The used to be away how an ancient libcurl version handled memory. 9 years later this has no value to be in there. If people need to know about it they can have a look at VCS logs. Closes curl#5973
bcc3fe9
to
97f3657
Compare
Thanks! (I edited the commit message somewhat) |
The comment described a way how an ancient libcurl version handled
memory. 9 years later this has no value to be in there. If people need
to know about it they can have a look at VCS logs.