Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checksrc: warn on space after exclamation mark #6034

Closed
wants to merge 1 commit into from

Conversation

@bagder
Copy link
Member

@bagder bagder commented Oct 2, 2020

No description provided.

@bagder bagder added the tidy-up label Oct 2, 2020
@@ -725,6 +726,12 @@ sub scanfile {
"typedef'ed struct");
}

if($nostr =~ /(.*)! +(\w|\()/) {

This comment has been minimized.

@danielgustafsson

danielgustafsson Oct 2, 2020
Member

Don't we want to use \s+ to handle any type of whitespace?

This comment has been minimized.

@bagder

bagder Oct 2, 2020
Author Member

Oh, maybe? Can there actually be any other whitespace that we don't already warn about elsewhere?

This comment has been minimized.

@danielgustafsson

danielgustafsson Oct 2, 2020
Member

Good point, it would be superfluous.

@bagder bagder closed this in 26a7d51 Oct 2, 2020
@bagder bagder deleted the bagder/exclamationspace branch Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.