Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ldap: reduce the amount of #ifdefs needed #6035

wants to merge 1 commit into from


Copy link

@bagder bagder commented Oct 2, 2020

No description provided.

@bagder bagder force-pushed the bagder/ldap-ifdefs branch from 5be8f49 to 60b8458 Oct 2, 2020
@@ -259,6 +259,13 @@ static int ldap_win_bind(struct connectdata *conn, LDAP *server,
#endif /* #if defined(USE_WIN32_LDAP) */

#if defined(USE_WIN32_LDAP)
#define FREE_ON_WINLDAP(x) curlx_unicodefree(x)

This comment has been minimized.


emilengler Oct 2, 2020

Shouldn't the curlx_unicodefree((c)) into two brackets like it is in other places

This comment has been minimized.


bagder Oct 2, 2020
Author Member

("brackets" are usually these: [] - I don't think you meant those)

I don't understand. Why do we need more parentheses?

This comment has been minimized.


emilengler Oct 3, 2020

I mean these () brackets. They are being used in other macros in the code as well. See Curl_safefree()

Copy link

@dfandrich dfandrich commented Oct 3, 2020

@bagder bagder closed this in 6497ed4 Oct 3, 2020
@bagder bagder deleted the bagder/ldap-ifdefs branch Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants