Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ldap: reduce the amount of #ifdefs needed #6035

Closed
wants to merge 1 commit into from
Closed

Conversation

bagder
Copy link
Member

@bagder bagder commented Oct 2, 2020

No description provided.

@@ -259,6 +259,13 @@ static int ldap_win_bind(struct connectdata *conn, LDAP *server,
}
#endif /* #if defined(USE_WIN32_LDAP) */

#if defined(USE_WIN32_LDAP)
#define FREE_ON_WINLDAP(x) curlx_unicodefree(x)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the curlx_unicodefree((c)) into two brackets like it is in other places

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

("brackets" are usually these: [] - I don't think you meant those)

I don't understand. Why do we need more parentheses?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean these () brackets. They are being used in other macros in the code as well. See Curl_safefree()

@dfandrich
Copy link
Contributor

dfandrich commented Oct 3, 2020 via email

@bagder bagder closed this in 6497ed4 Oct 3, 2020
@bagder bagder deleted the bagder/ldap-ifdefs branch October 3, 2020 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants