Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd mbedTLS support to nmake build system #606
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
mention-bot
Jan 17, 2016
By analyzing the blame information on this pull request, we identified @captain-caveman2k, @bagder and @yangtse to be potential reviewers
mention-bot
commented
Jan 17, 2016
|
By analyzing the blame information on this pull request, we identified @captain-caveman2k, @bagder and @yangtse to be potential reviewers |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
bagder
Apr 9, 2016
Member
Do you still think this is a good idea? It seems this patch now needs to be rebased to work again...
|
Do you still think this is a good idea? It seems this patch now needs to be rebased to work again... |
bagder
added
the
build
label
Apr 9, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
I'll take a look at it tomorrow after uni. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
I've rebased it on top of the master branch. |
bagder
closed this
in
5d8093e
Apr 21, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
Thanks, merged now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
BurningEnlightenment commentedJan 17, 2016
I modified the nmake scripts to accept an additional WITH_MBEDTLS option which works almost exactly like the WITH_SSL option.
I used the autoconf script as a reference for this implementation and it works well with Visual Studio 2015. If I missed something important I'll fix it ASAP.
Cheers,
Henrik