Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mbedTLS support to nmake build system #606

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@BurningEnlightenment
Copy link
Contributor

commented Jan 17, 2016

I modified the nmake scripts to accept an additional WITH_MBEDTLS option which works almost exactly like the WITH_SSL option.
I used the autoconf script as a reference for this implementation and it works well with Visual Studio 2015. If I missed something important I'll fix it ASAP.

Cheers,
Henrik

@mention-bot

This comment has been minimized.

Copy link

commented Jan 17, 2016

By analyzing the blame information on this pull request, we identified @captain-caveman2k, @bagder and @yangtse to be potential reviewers

@bagder

This comment has been minimized.

Copy link
Member

commented Apr 9, 2016

Do you still think this is a good idea? It seems this patch now needs to be rebased to work again...

@bagder bagder added the build label Apr 9, 2016

@BurningEnlightenment

This comment has been minimized.

Copy link
Contributor Author

commented Apr 10, 2016

I'll take a look at it tomorrow after uni.

ADD mbedTLS SUPPORT TO NMAKE BUILD SYSTEM
Add WITH_MBEDTLS nmake option. Make WITH_SSL, WITH_MBEDTLS and
ENABLE_WINSSL options mutual exclusive.
@BurningEnlightenment

This comment has been minimized.

Copy link
Contributor Author

commented Apr 11, 2016

I've rebased it on top of the master branch.

@bagder bagder closed this in 5d8093e Apr 21, 2016

@bagder

This comment has been minimized.

Copy link
Member

commented Apr 21, 2016

Thanks, merged now!

@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.