Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd mbedTLS support to nmake build system #606
Closed
Conversation
This comment has been minimized.
This comment has been minimized.
mention-bot
commented
Jan 17, 2016
|
By analyzing the blame information on this pull request, we identified @captain-caveman2k, @bagder and @yangtse to be potential reviewers |
This comment has been minimized.
This comment has been minimized.
|
Do you still think this is a good idea? It seems this patch now needs to be rebased to work again... |
This comment has been minimized.
This comment has been minimized.
|
I'll take a look at it tomorrow after uni. |
Add WITH_MBEDTLS nmake option. Make WITH_SSL, WITH_MBEDTLS and ENABLE_WINSSL options mutual exclusive.
This comment has been minimized.
This comment has been minimized.
|
I've rebased it on top of the master branch. |
This comment has been minimized.
This comment has been minimized.
|
Thanks, merged now! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
BurningEnlightenment commentedJan 17, 2016
I modified the nmake scripts to accept an additional WITH_MBEDTLS option which works almost exactly like the WITH_SSL option.
I used the autoconf script as a reference for this implementation and it works well with Visual Studio 2015. If I missed something important I'll fix it ASAP.
Cheers,
Henrik