Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: make BUILD_TESTING dependent option #6072

Closed
wants to merge 1 commit into from

Conversation

@snikulov
Copy link
Member

@snikulov snikulov commented Oct 13, 2020

Make BUILD_TESTING option dependant on PERL_FOUND and CURL_DISABLE_TESTS

The main idea that Curl testing should be enabled in the following case
PERL_FOUND is True AND CURL_DISABLE_TESTS is False

CURL_DISABLE_TESTS can be used to explicitly disable tests when libcurl is included as a subproject/subdirectory when BUILD_TESTING is enabled for the parent project.

Ref: #6036

CMake will now handle BUILD_TESTING depending
on PERL_FOUND and CURL_DISABLE_TESTING

Ref: #6036
@snikulov snikulov added the cmake label Oct 13, 2020
@snikulov snikulov requested review from jzakrzewski and Lekensteyn Oct 13, 2020
Copy link
Contributor

@jzakrzewski jzakrzewski left a comment

Sorry it took so long - I really wanted to test the interaction with a top-level project first.
Thanks!

@bagder
Copy link
Member

@bagder bagder commented Oct 29, 2020

Thanks!

@bagder bagder closed this in 3a1e798 Oct 29, 2020
@snikulov snikulov deleted the snikulov:cmake_build_testing branch Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.