Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: use ninja-build for CMake builds #6077

Merged
merged 1 commit into from Nov 4, 2020

Conversation

snikulov
Copy link
Member

@snikulov snikulov commented Oct 14, 2020

Added package ninja-build to TravisCI environment
Use ninja to speed up CMake builds

Should speed up build a bit.

@snikulov snikulov added build cmake CI labels Oct 14, 2020
@snikulov snikulov force-pushed the travisci_cmake_use_ninja branch from c1bf77d to 19776f7 Compare Oct 14, 2020
@snikulov snikulov requested review from jay, mback2k and bagder Oct 15, 2020
bagder
bagder approved these changes Oct 15, 2020
Copy link
Member

@mback2k mback2k left a comment

Seems fine to me, but now we won't be testing CMake generating classic Makefiles for us anymore, right?

@snikulov
Copy link
Member Author

@snikulov snikulov commented Oct 16, 2020

@mback2k yes. I think such tests should be done by CMake guys.
I'm still wondering why BoringSSL been built twice.
But I leave it as it was for Makefiles.
Thought maybe someone will shed some light on this...

@mback2k mback2k requested a review from MarcelRaad Oct 19, 2020
Added package ninja-build to environment
Use ninja to speed up CMake builds

Closes curl#6077
@snikulov snikulov force-pushed the travisci_cmake_use_ninja branch from 19776f7 to 8891805 Compare Nov 3, 2020
@snikulov snikulov merged commit e41ba40 into curl:master Nov 4, 2020
44 of 48 checks passed
@snikulov
Copy link
Member Author

@snikulov snikulov commented Nov 4, 2020

merged as e41ba40

@snikulov snikulov deleted the travisci_cmake_use_ninja branch Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build CI cmake
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants