-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
appveyor: disable test 571 in two cmake builds #6119
Conversation
... they're simply too flaky there.
Why not mark them as flaky? Is there anything special to these two build configurations? |
Only because I don't want to disable them for every build everywhere. Ideally we introduce a way in the future to give us more qualifiers to "flaky". Like platforms, build combinations etc. |
You could start now. Just mark this test as flaky-cmake and add !flaky-cmake to
the test keywords it uses. The mechanism can always be tweaked later.
|
For this I introduced the |
Also this seems to be the AppVeyor equivalent of #5954. Unfortunately I wasn't able to debug this RTSP test on Windows (yet). |
But its cmake-on-appveyor, or possibly cmake-on-win32. I think I rather stick to disabling it in appveyor for now. |
Yeah, if it's that specific then that's probably best.
|
Actually it is either not working due to MinGW, MSYS or Win32 since it is also broken for the autotools based builds on Azure Pipelines. So I don't think this is caused by CMake. |
Short term, we can keep adding test numbers to ignore in the CI setup files, and then we can go over them all and see which are ignored where and see if we can draw conclusions and/or make better systems to handle them. |
... they're simply too flaky there.