Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix some http/2 tests for older versions of nghttpx #6139

Closed
wants to merge 1 commit into from

Conversation

@jay
Copy link
Member

@jay jay commented Oct 29, 2020

  • Add regex that strips http/2 server header name to those http/2 tests
    that don't already have it.

  • Improve that regex in all http/2 tests.

Tests 358 and 359 were failing for me before this change on a system
that uses an older version of nghttpx which includes its version number
in the server header.

Closes #xxxx


nghttpx has --server-name which would be a better choice to make a uniform server name however it's not available in some older versions that are still supported.

- Add regex that strips http/2 server header name to those http/2 tests
  that don't already have it.

- Improve that regex in all http/2 tests.

Tests 358 and 359 were failing for me before this change on a system
that uses an older version of nghttpx which includes its version number
in the server header.

Closes #xxxx
@jay jay added HTTP/2 tests labels Oct 29, 2020
@bagder
bagder approved these changes Oct 29, 2020
@jay jay closed this in e4d3801 Oct 30, 2020
@jay jay deleted the jay:fix_http2_tests_for_oldver branch Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.