Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtsp: fixed Session ID comparison to refuse prefix #6161

Closed
wants to merge 3 commits into from
Closed

Conversation

@piru
Copy link

@piru piru commented Nov 3, 2020

Fixes an oversight in the RTSP Session ID comparison: It would accept any Session ID from the server that is prefixed by the one specified by CURLOPT_RTSP_SESSION_ID.

Blank Session ID will now result in CURLE_RTSP_SESSION_ERROR.

@piru
Copy link
Author

@piru piru commented Nov 3, 2020

Wait huh is test570 wrong or have I really misunderstood how RTSP Session header works?

@bagder bagder added the RTSP label Nov 3, 2020
Harry Sintonen added 2 commits Nov 3, 2020
@piru
Copy link
Author

@piru piru commented Nov 3, 2020

Wait huh is test570 wrong or have I really misunderstood how RTSP Session header works?

Right, the test was broken, now fixed.

@bagder
Copy link
Member

@bagder bagder commented Nov 4, 2020

Thanks!

@bagder bagder closed this in adb0fcf Nov 4, 2020
bagder added a commit that referenced this pull request Nov 4, 2020
Closes #6161
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.