cmake // build issue when OpenSSL enabled on Windows and schannel detected #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @jzakrzewski, @billhoffman and @Sukender to be potential reviewers |
snikulov
changed the title
snikulov
force-pushed
the
fix_openssl_schannel_clash
branch
from
a7ae284
to
cf66976
Compare
|
@bradking Could you please review? |
| mark_as_advanced(CMAKE_USE_OPENSSL) | ||
|
|
||
| if(WIN32) | ||
| CMAKE_DEPENDENT_OPTION(CURL_WINDOWS_SSPI "Use windows libraries to allow NTLM authentication without openssl" OFF | ||
| "CMAKE_USE_OPENSSL" ON) |
There was a problem hiding this comment.
IIUC the goal is to present the CURL_WINDOWS_SSPI option (with default ON) when CMAKE_USE_OPENSSL is OFF (default). When CMAKE_USE_OPENSSL is ON then CURL_WINDOWS_SSPI should be non-optional and forced to OFF. In that case the dependent option should be:
CMAKE_DEPENDENT_OPTION(CURL_WINDOWS_SSPI "Use windows libraries to allow NTLM authentication without openssl" ON
"NOT CMAKE_USE_OPENSSL" OFF)
|
@bradking updated per your comments with snikulov@b2e6d0a If it looks OK for you - I'll squash it into single commit. |
|
Yes, LGTM. |
snikulov
force-pushed
the
fix_openssl_schannel_clash
branch
from
b2e6d0a
to
9a7486e
Compare
|
@bagder I'm done. |
|
thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Options OpenSSL and Windows Schannel should be exclusive.
Enabling them both will break the build - we got redefinition in
ssl_connect_datastructure (ref to Appveyour buils).So on Windows I disable CMAKE_USE_OPENSSL by default (Windows Schannel is preferred).
But we always can override this option with
cmake .. -DCMAKE_USE_OPENNSSL=ON| OFF