Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upcmake // build issue when OpenSSL enabled on Windows and schannel detected #617
Conversation
This comment has been minimized.
This comment has been minimized.
mention-bot
commented
Jan 27, 2016
|
By analyzing the blame information on this pull request, we identified @jzakrzewski, @billhoffman and @Sukender to be potential reviewers |
snikulov
changed the title
Fixed build issue when OpenSSL enabled on Windows and schannel detected
cmake // build issue when OpenSSL enabled on Windows and schannel detected
Jan 27, 2016
snikulov
force-pushed the
snikulov:fix_openssl_schannel_clash
branch
Jan 27, 2016
This comment has been minimized.
This comment has been minimized.
|
@bradking Could you please review? |
bradking
reviewed
Jan 27, 2016
View changes
| mark_as_advanced(CMAKE_USE_OPENSSL) | ||
|
|
||
| if(WIN32) | ||
| CMAKE_DEPENDENT_OPTION(CURL_WINDOWS_SSPI "Use windows libraries to allow NTLM authentication without openssl" OFF | ||
| "CMAKE_USE_OPENSSL" ON) |
This comment has been minimized.
This comment has been minimized.
bradking
Jan 27, 2016
Contributor
IIUC the goal is to present the CURL_WINDOWS_SSPI option (with default ON) when CMAKE_USE_OPENSSL is OFF (default). When CMAKE_USE_OPENSSL is ON then CURL_WINDOWS_SSPI should be non-optional and forced to OFF. In that case the dependent option should be:
CMAKE_DEPENDENT_OPTION(CURL_WINDOWS_SSPI "Use windows libraries to allow NTLM authentication without openssl" ON
"NOT CMAKE_USE_OPENSSL" OFF)
This comment has been minimized.
This comment has been minimized.
|
@bradking updated per your comments with snikulov@b2e6d0a If it looks OK for you - I'll squash it into single commit. |
This comment has been minimized.
This comment has been minimized.
|
Yes, LGTM. |
bagder
added
build
cmake
labels
Jan 28, 2016
snikulov
force-pushed the
snikulov:fix_openssl_schannel_clash
branch
to
9a7486e
Jan 28, 2016
This comment has been minimized.
This comment has been minimized.
|
@bagder I'm done. |
bagder
closed this
in
a8135f0
Jan 28, 2016
This comment has been minimized.
This comment has been minimized.
|
thanks! |
lock
bot
locked as resolved and limited conversation to collaborators
Jan 19, 2019
snikulov commentedJan 27, 2016
Options OpenSSL and Windows Schannel should be exclusive.
Enabling them both will break the build - we got redefinition in
ssl_connect_datastructure (ref to Appveyour buils).So on Windows I disable CMAKE_USE_OPENSSL by default (Windows Schannel is preferred).
But we always can override this option with
cmake .. -DCMAKE_USE_OPENNSSL=ON| OFF