Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtests.pl: kill processes locking test log files #6179

Closed
wants to merge 2 commits into from
Closed

runtests.pl: kill processes locking test log files #6179

wants to merge 2 commits into from

Conversation

mback2k
Copy link
Member

@mback2k mback2k commented Nov 5, 2020

For now only required and implemented for Windows.

Ref: #6058

@mback2k mback2k added tests Windows Windows-specific labels Nov 5, 2020
@mback2k mback2k self-assigned this Nov 5, 2020
@ghost
Copy link

ghost commented Nov 9, 2020 •
edited by ghost

Congratulations 🎉. DeepCode analyzed your code in 0.315 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

mback2k added a commit to mback2k/curl that referenced this pull request Nov 11, 2020
@mback2k
runtests.pl: kill processes locking test log files
15bee56 
For now only required and implemented for Windows.

Requires Sysinternals handle[64].exe to be on PATH.

Ref: curl#6058
Closes curl#6179
mback2k added a commit to mback2k/curl that referenced this pull request Nov 11, 2020
@mback2k
pathhelp.pm: fix use of pwd -L in Msys environment
9dd808f 
While Msys2 has a pwd binary which supports -L,
Msys1 only has a built-in one with that feature.

Part of curl#6179
mback2k added a commit to mback2k/curl that referenced this pull request Nov 11, 2020
@mback2k
pathhelp.pm: fix use of pwd -L in Msys environment
df9e661 
While Msys2 has a pwd binary which supports -L,
Msys1 only has a built-in one with that feature.

Part of curl#6179
@mback2k mback2k mentioned this pull request Nov 12, 2020
Closed
mback2k added a commit to mback2k/curl that referenced this pull request Nov 14, 2020
@mback2k
runtests.pl: kill processes locking test log files
456be0e 
For now only required and implemented for Windows.

Requires Sysinternals handle[64].exe to be on PATH.

Ref: curl#6058
Closes curl#6179
mback2k added a commit to mback2k/curl that referenced this pull request Nov 14, 2020
@mback2k
pathhelp.pm: fix use of pwd -L in Msys environment
996ad3b 
While Msys2 has a pwd binary which supports -L,
Msys1 only has a built-in one with that feature.

Part of curl#6179
mback2k added a commit to mback2k/curl that referenced this pull request Nov 14, 2020
@mback2k
runtests.pl: kill processes locking test log files
a3f95d8 
For now only required and implemented for Windows.

Requires Sysinternals handle[64].exe to be on PATH.

Ref: curl#6058
Closes curl#6179
mback2k added a commit to mback2k/curl that referenced this pull request Nov 14, 2020
@mback2k
pathhelp.pm: fix use of pwd -L in Msys environment
0a2bd30 
While Msys2 has a pwd binary which supports -L,
Msys1 only has a built-in one with that feature.

Part of curl#6179
mback2k added a commit to mback2k/curl that referenced this pull request Nov 15, 2020
@mback2k
pathhelp.pm: fix use of pwd -L in Msys environment
fae4aa2 
While Msys2 has a pwd binary which supports -L,
Msys1 only has a built-in one with that feature.

Part of curl#6179
mback2k added a commit to mback2k/curl that referenced this pull request Nov 15, 2020
@mback2k
runtests.pl: kill processes locking test log files
a9c21b9 
For now only required and implemented for Windows.

Requires Sysinternals handle[64].exe to be on PATH.

Ref: curl#6058
Closes curl#6179
@mback2k mback2k mentioned this pull request Nov 16, 2020
Closed
mback2k added a commit to mback2k/curl that referenced this pull request Nov 16, 2020
@mback2k
runtests.pl: kill processes locking test log files
ffcdffc 
For now only required and implemented for Windows.
Ignore stunnel logs due to long running processes.

Requires Sysinternals handle[64].exe to be on PATH.

Ref: curl#6058
Closes curl#6179
mback2k added a commit to mback2k/curl that referenced this pull request Nov 20, 2020
@mback2k
pathhelp.pm: fix use of pwd -L in Msys environment
26c928a 
While Msys2 has a pwd binary which supports -L,
Msys1 only has a built-in one with that feature.

Part of curl#6179
mback2k added a commit to mback2k/curl that referenced this pull request Nov 20, 2020
@mback2k
runtests.pl: kill processes locking test log files
8e8d6e5 
For now only required and implemented for Windows.
Ignore stunnel logs due to long running processes.

Requires Sysinternals handle[64].exe to be on PATH.

Ref: curl#6058
Closes curl#6179
@mback2k
Copy link
Member Author

mback2k commented Dec 5, 2020

I will continue working on this. I also plan to implement Linux/macOS support for this via lsof.

@bagder
Copy link
Member

bagder commented Dec 21, 2020

on Linux and macOS the files aren't "locked" when another process is reading/writing them so what would the reason and idea be for this on those platforms?

@mback2k
Copy link
Member Author

mback2k commented Dec 21, 2020

on Linux and macOS the files aren't "locked" when another process is reading/writing them so what would the reason and idea be for this on those platforms?

That is correct, but it would still be good to know if the files are kept open while they should already be closed. So the detection part is probably a good idea, but maybe not the process killing part.

mback2k added a commit to mback2k/curl that referenced this pull request Dec 26, 2020
@mback2k
pathhelp.pm: fix use of pwd -L in Msys environment
bc69aea 
While Msys2 has a pwd binary which supports -L,
Msys1 only has a built-in one with that feature.

Part of curl#6179
mback2k added a commit to mback2k/curl that referenced this pull request Dec 26, 2020
@mback2k
runtests.pl: kill processes locking test log files
8918776 
For now only required and implemented for Windows.
Ignore stunnel logs due to long running processes.

Requires Sysinternals handle[64].exe to be on PATH.

Ref: curl#6058
Closes curl#6179
mback2k added a commit to mback2k/curl that referenced this pull request Feb 27, 2021
@mback2k
pathhelp.pm: fix use of pwd -L in Msys environment
3bc9549 
While Msys2 has a pwd binary which supports -L,
Msys1 only has a built-in one with that feature.

Part of curl#6179
mback2k added a commit to mback2k/curl that referenced this pull request Feb 27, 2021
@mback2k
runtests.pl: kill processes locking test log files
52b9674 
For now only required and implemented for Windows.
Ignore stunnel logs due to long running processes.

Requires Sysinternals handle[64].exe to be on PATH.

Ref: curl#6058
Closes curl#6179
@mback2k
Copy link
Member Author

mback2k commented Feb 27, 2021

@bagder you were right, since the deletion of "locked" files won't fail, the detection part wouldn't even run like on Windows.

@mback2k mback2k marked this pull request as ready for review February 27, 2021 20:26
@mback2k
Copy link
Member Author

mback2k commented Feb 27, 2021

Rebased and ready for review.

jay
jay reviewed Feb 28, 2021
View reviewed changes
tests/pathhelp.pm Show resolved Hide resolved
jay
jay reviewed Feb 28, 2021
View reviewed changes
tests/runtests.pl Show resolved Hide resolved
jay
jay reviewed Feb 28, 2021
View reviewed changes
tests/runtests.pl Show resolved Hide resolved
jay
jay reviewed Feb 28, 2021
View reviewed changes
Copy link
Member

@jay jay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should make this behavior an option, like runtests.pl -f forcibly kill lingering processes or something. This seems like a diagnostic for us to run in the CI and not for default use.

@mback2k
Copy link
Member Author

mback2k commented Feb 28, 2021

I consider it a general part for CI runs that should always be enabled, but yes: a flag for outside of CI makes sense.

mback2k added a commit to mback2k/curl that referenced this pull request Feb 28, 2021
@mback2k
runtests.pl: kill processes locking test log files
ec6cff5 
For now only required and implemented for Windows.
Ignore stunnel logs due to long running processes.

Requires Sysinternals handle[64].exe to be on PATH.

Reviewed-by: Jay Satiro

Ref: curl#6058
Closes curl#6179
jay
jay approved these changes Feb 28, 2021
View reviewed changes
Copy link
Member

@jay jay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message should say that this is a new option

@mback2k
pathhelp.pm: fix use of pwd -L in Msys environment
02fa331 
While Msys2 has a pwd binary which supports -L,
Msys1 only has a built-in one with that feature.

Part of curl#6179
@mback2k
runtests.pl: kill processes locking test log files
22a346c 
Introduce a new runtests.pl command option: -rm

For now only required and implemented for Windows.
Ignore stunnel logs due to long running processes.

Requires Sysinternals handle[64].exe to be on PATH.

Reviewed-by: Jay Satiro

Ref: curl#6058
Closes curl#6179
mback2k added a commit that referenced this pull request Mar 1, 2021
@mback2k
pathhelp.pm: fix use of pwd -L in Msys environment
b2b3c91 
While Msys2 has a pwd binary which supports -L,
Msys1 only has a shell built-in with that feature.

Reviewed-by: Jay Satiro

Part of #6179
@mback2k mback2k closed this in 311c31e Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jay jay jay approved these changes

@bagder bagder Awaiting requested review from bagder

@MarcelRaad MarcelRaad Awaiting requested review from MarcelRaad

Assignees

@mback2k mback2k

Labels
tests Windows Windows-specific
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mback2k @bagder @jay