New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtests.pl: kill processes locking test log files #6179
Conversation
|
While Msys2 has a pwd binary which supports -L, Msys1 only has a built-in one with that feature. Part of curl#6179
While Msys2 has a pwd binary which supports -L, Msys1 only has a built-in one with that feature. Part of curl#6179
While Msys2 has a pwd binary which supports -L, Msys1 only has a built-in one with that feature. Part of curl#6179
While Msys2 has a pwd binary which supports -L, Msys1 only has a built-in one with that feature. Part of curl#6179
While Msys2 has a pwd binary which supports -L, Msys1 only has a built-in one with that feature. Part of curl#6179
While Msys2 has a pwd binary which supports -L, Msys1 only has a built-in one with that feature. Part of curl#6179
I will continue working on this. I also plan to implement Linux/macOS support for this via |
on Linux and macOS the files aren't "locked" when another process is reading/writing them so what would the reason and idea be for this on those platforms? |
That is correct, but it would still be good to know if the files are kept open while they should already be closed. So the detection part is probably a good idea, but maybe not the process killing part. |
While Msys2 has a pwd binary which supports -L, Msys1 only has a built-in one with that feature. Part of curl#6179
While Msys2 has a pwd binary which supports -L, Msys1 only has a built-in one with that feature. Part of curl#6179
@bagder you were right, since the deletion of "locked" files won't fail, the detection part wouldn't even run like on Windows. |
Rebased and ready for review. |
I think you should make this behavior an option, like runtests.pl -f forcibly kill lingering processes or something. This seems like a diagnostic for us to run in the CI and not for default use.
I consider it a general part for CI runs that should always be enabled, but yes: a flag for outside of CI makes sense. |
While Msys2 has a pwd binary which supports -L, Msys1 only has a built-in one with that feature. Part of curl#6179
While Msys2 has a pwd binary which supports -L, Msys1 only has a shell built-in with that feature. Reviewed-by: Jay Satiro Part of #6179
For now only required and implemented for Windows.
Ref: #6058