New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtests.pl: kill processes locking test log files #6179
Conversation
c569903
to
b7742e1
Compare
👉 View analysis in DeepCode’s Dashboard | Configure the bot |
05486b6
to
9dd808f
Compare
While Msys2 has a pwd binary which supports -L, Msys1 only has a built-in one with that feature. Part of curl#6179
While Msys2 has a pwd binary which supports -L, Msys1 only has a built-in one with that feature. Part of curl#6179
9dd808f
to
df9e661
Compare
36ffbec
to
f25af18
Compare
While Msys2 has a pwd binary which supports -L, Msys1 only has a built-in one with that feature. Part of curl#6179
f25af18
to
3f443f2
Compare
While Msys2 has a pwd binary which supports -L, Msys1 only has a built-in one with that feature. Part of curl#6179
3f443f2
to
7d0b643
Compare
While Msys2 has a pwd binary which supports -L, Msys1 only has a built-in one with that feature. Part of curl#6179
7d0b643
to
a9c21b9
Compare
a9c21b9
to
ffcdffc
Compare
While Msys2 has a pwd binary which supports -L, Msys1 only has a built-in one with that feature. Part of curl#6179
ffcdffc
to
8e8d6e5
Compare
I will continue working on this. I also plan to implement Linux/macOS support for this via |
on Linux and macOS the files aren't "locked" when another process is reading/writing them so what would the reason and idea be for this on those platforms? |
That is correct, but it would still be good to know if the files are kept open while they should already be closed. So the detection part is probably a good idea, but maybe not the process killing part. |
While Msys2 has a pwd binary which supports -L, Msys1 only has a built-in one with that feature. Part of curl#6179
8e8d6e5
to
8918776
Compare
While Msys2 has a pwd binary which supports -L, Msys1 only has a built-in one with that feature. Part of curl#6179
8918776
to
52b9674
Compare
@bagder you were right, since the deletion of "locked" files won't fail, the detection part wouldn't even run like on Windows. |
Rebased and ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should make this behavior an option, like runtests.pl -f forcibly kill lingering processes or something. This seems like a diagnostic for us to run in the CI and not for default use.
I consider it a general part for CI runs that should always be enabled, but yes: a flag for outside of CI makes sense. |
52b9674
to
ec6cff5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit message should say that this is a new option
While Msys2 has a pwd binary which supports -L, Msys1 only has a built-in one with that feature. Part of curl#6179
ec6cff5
to
22a346c
Compare
While Msys2 has a pwd binary which supports -L, Msys1 only has a shell built-in with that feature. Reviewed-by: Jay Satiro Part of #6179
For now only required and implemented for Windows.
Ref: #6058