runtests.pl: kill processes locking test log files #6179

mback2k · 2020-11-05T21:02:31Z

For now only required and implemented for Windows.

deepcode-ci-bot · 2020-11-09T19:33:11Z

Congratulations 🎉. DeepCode analyzed your code in 0.315 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

For now only required and implemented for Windows. Requires Sysinternals handle[64].exe to be on PATH. Ref: curl#6058 Closes curl#6179

While Msys2 has a pwd binary which supports -L, Msys1 only has a built-in one with that feature. Part of curl#6179

For now only required and implemented for Windows. Requires Sysinternals handle[64].exe to be on PATH. Ref: curl#6058 Closes curl#6179

While Msys2 has a pwd binary which supports -L, Msys1 only has a built-in one with that feature. Part of curl#6179

For now only required and implemented for Windows. Requires Sysinternals handle[64].exe to be on PATH. Ref: curl#6058 Closes curl#6179

While Msys2 has a pwd binary which supports -L, Msys1 only has a built-in one with that feature. Part of curl#6179

For now only required and implemented for Windows. Requires Sysinternals handle[64].exe to be on PATH. Ref: curl#6058 Closes curl#6179

For now only required and implemented for Windows. Ignore stunnel logs due to long running processes. Requires Sysinternals handle[64].exe to be on PATH. Ref: curl#6058 Closes curl#6179

While Msys2 has a pwd binary which supports -L, Msys1 only has a built-in one with that feature. Part of curl#6179

For now only required and implemented for Windows. Ignore stunnel logs due to long running processes. Requires Sysinternals handle[64].exe to be on PATH. Ref: curl#6058 Closes curl#6179

mback2k · 2020-12-05T21:09:48Z

I will continue working on this. I also plan to implement Linux/macOS support for this via lsof.

bagder · 2020-12-21T16:05:05Z

on Linux and macOS the files aren't "locked" when another process is reading/writing them so what would the reason and idea be for this on those platforms?

mback2k · 2020-12-21T16:17:16Z

on Linux and macOS the files aren't "locked" when another process is reading/writing them so what would the reason and idea be for this on those platforms?

That is correct, but it would still be good to know if the files are kept open while they should already be closed. So the detection part is probably a good idea, but maybe not the process killing part.

While Msys2 has a pwd binary which supports -L, Msys1 only has a built-in one with that feature. Part of curl#6179

For now only required and implemented for Windows. Ignore stunnel logs due to long running processes. Requires Sysinternals handle[64].exe to be on PATH. Ref: curl#6058 Closes curl#6179

While Msys2 has a pwd binary which supports -L, Msys1 only has a built-in one with that feature. Part of curl#6179

For now only required and implemented for Windows. Ignore stunnel logs due to long running processes. Requires Sysinternals handle[64].exe to be on PATH. Ref: curl#6058 Closes curl#6179

mback2k · 2021-02-27T20:26:34Z

@bagder you were right, since the deletion of "locked" files won't fail, the detection part wouldn't even run like on Windows.

mback2k · 2021-02-27T20:26:53Z

Rebased and ready for review.

tests/pathhelp.pm

tests/runtests.pl

jay

I think you should make this behavior an option, like runtests.pl -f forcibly kill lingering processes or something. This seems like a diagnostic for us to run in the CI and not for default use.

mback2k · 2021-02-28T06:33:02Z

I consider it a general part for CI runs that should always be enabled, but yes: a flag for outside of CI makes sense.

For now only required and implemented for Windows. Ignore stunnel logs due to long running processes. Requires Sysinternals handle[64].exe to be on PATH. Reviewed-by: Jay Satiro Ref: curl#6058 Closes curl#6179

jay

The commit message should say that this is a new option

While Msys2 has a pwd binary which supports -L, Msys1 only has a built-in one with that feature. Part of #6179

Introduce a new runtests.pl command option: -rm For now only required and implemented for Windows. Ignore stunnel logs due to long running processes. Requires Sysinternals handle[64].exe to be on PATH. Reviewed-by: Jay Satiro Ref: #6058 Closes #6179

While Msys2 has a pwd binary which supports -L, Msys1 only has a shell built-in with that feature. Reviewed-by: Jay Satiro Part of #6179

mback2k added tests Windows labels Nov 5, 2020

mback2k self-assigned this Nov 5, 2020

mback2k force-pushed the mback2k:runtests-checklocks branch from c569903 to b7742e1 Nov 6, 2020

mback2k force-pushed the mback2k:runtests-checklocks branch from 05486b6 to 9dd808f Nov 11, 2020

mback2k added a commit to mback2k/curl that referenced this pull request Nov 11, 2020

runtests.pl: kill processes locking test log files

15bee56

For now only required and implemented for Windows. Requires Sysinternals handle[64].exe to be on PATH. Ref: curl#6058 Closes curl#6179

mback2k added a commit to mback2k/curl that referenced this pull request Nov 11, 2020

pathhelp.pm: fix use of pwd -L in Msys environment

9dd808f

While Msys2 has a pwd binary which supports -L, Msys1 only has a built-in one with that feature. Part of curl#6179

mback2k added a commit to mback2k/curl that referenced this pull request Nov 11, 2020

pathhelp.pm: fix use of pwd -L in Msys environment

df9e661

While Msys2 has a pwd binary which supports -L, Msys1 only has a built-in one with that feature. Part of curl#6179

mback2k force-pushed the mback2k:runtests-checklocks branch from 9dd808f to df9e661 Nov 11, 2020

mback2k mentioned this pull request Nov 12, 2020

Weird mixup of test data in test suite run #6058

Closed

mback2k force-pushed the mback2k:runtests-checklocks branch from 36ffbec to f25af18 Nov 13, 2020

mback2k force-pushed the mback2k:runtests-checklocks branch from f25af18 to 3f443f2 Nov 14, 2020

mback2k added a commit to mback2k/curl that referenced this pull request Nov 14, 2020

runtests.pl: kill processes locking test log files

a3f95d8

For now only required and implemented for Windows. Requires Sysinternals handle[64].exe to be on PATH. Ref: curl#6058 Closes curl#6179

mback2k added a commit to mback2k/curl that referenced this pull request Nov 14, 2020

pathhelp.pm: fix use of pwd -L in Msys environment

0a2bd30

While Msys2 has a pwd binary which supports -L, Msys1 only has a built-in one with that feature. Part of curl#6179

mback2k force-pushed the mback2k:runtests-checklocks branch from 3f443f2 to 7d0b643 Nov 14, 2020

mback2k added a commit to mback2k/curl that referenced this pull request Nov 15, 2020

pathhelp.pm: fix use of pwd -L in Msys environment

fae4aa2

While Msys2 has a pwd binary which supports -L, Msys1 only has a built-in one with that feature. Part of curl#6179

mback2k added a commit to mback2k/curl that referenced this pull request Nov 15, 2020

runtests.pl: kill processes locking test log files

a9c21b9

For now only required and implemented for Windows. Requires Sysinternals handle[64].exe to be on PATH. Ref: curl#6058 Closes curl#6179

mback2k force-pushed the mback2k:runtests-checklocks branch from 7d0b643 to a9c21b9 Nov 15, 2020

mback2k mentioned this pull request Nov 16, 2020

tests/server/tftpd.c: close upload file after transfer #6209

Closed

mback2k force-pushed the mback2k:runtests-checklocks branch from a9c21b9 to ffcdffc Nov 16, 2020

mback2k added a commit to mback2k/curl that referenced this pull request Nov 20, 2020

pathhelp.pm: fix use of pwd -L in Msys environment

26c928a

While Msys2 has a pwd binary which supports -L, Msys1 only has a built-in one with that feature. Part of curl#6179

mback2k force-pushed the mback2k:runtests-checklocks branch from ffcdffc to 8e8d6e5 Nov 20, 2020

mback2k force-pushed the mback2k:runtests-checklocks branch from 8e8d6e5 to 8918776 Dec 26, 2020

mback2k force-pushed the mback2k:runtests-checklocks branch from 8918776 to 52b9674 Feb 27, 2021

mback2k marked this pull request as ready for review Feb 27, 2021

mback2k requested review from bagder, jay and MarcelRaad Feb 27, 2021

jay reviewed Feb 28, 2021

View changes

tests/pathhelp.pm Show resolved Hide resolved

jay reviewed Feb 28, 2021

View changes

tests/runtests.pl Show resolved Hide resolved

jay reviewed Feb 28, 2021

View changes

tests/runtests.pl Show resolved Hide resolved

jay reviewed Feb 28, 2021

View changes

mback2k force-pushed the mback2k:runtests-checklocks branch from 52b9674 to ec6cff5 Feb 28, 2021

jay approved these changes Feb 28, 2021

View changes

mback2k added 2 commits Nov 11, 2020

mback2k force-pushed the mback2k:runtests-checklocks branch from ec6cff5 to 22a346c Feb 28, 2021

mback2k closed this in 311c31e Mar 1, 2021

curl / curl

runtests.pl: kill processes locking test log files #6179

runtests.pl: kill processes locking test log files #6179

mback2k commented Nov 5, 2020

deepcode-ci-bot bot commented Nov 9, 2020 •

edited

mback2k commented Dec 5, 2020

bagder commented Dec 21, 2020

mback2k commented Dec 21, 2020

mback2k commented Feb 27, 2021

mback2k commented Feb 27, 2021

jay left a comment

mback2k commented Feb 28, 2021

jay left a comment

curl / curl

Sponsor curl/curl

runtests.pl: kill processes locking test log files #6179

runtests.pl: kill processes locking test log files #6179

Conversation

mback2k commented Nov 5, 2020

deepcode-ci-bot bot commented Nov 9, 2020 • edited

👉 View analysis in DeepCode’s Dashboard | Configure the bot

mback2k commented Dec 5, 2020

bagder commented Dec 21, 2020

mback2k commented Dec 21, 2020

mback2k commented Feb 27, 2021

mback2k commented Feb 27, 2021

jay left a comment

mback2k commented Feb 28, 2021

jay left a comment

deepcode-ci-bot bot commented Nov 9, 2020 •

edited