Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't pass -fvisibility=hidden to clang-cl on Windows #6194

Closed
wants to merge 1 commit into from

Conversation

@tru
Copy link
Contributor

@tru tru commented Nov 10, 2020

When using clang-cl on windows -fvisibility=hidden is not
an known argument. Instead it behaves exactly like MSVC in
this case. So let's make sure we take that path.

In CMake clang-cl sets both CMAKE_C_COMPILER_ID=clang and
MSVC get's defined since clang-cl is basically a MSVC
emulator. So guarding like we do in this patch seems logical.

When using clang-cl on windows -fvisibility=hidden is not
an known argument. Instead it behaves exactly like MSVC in
this case. So let's make sure we take that path.

In CMake clang-cl sets both CMAKE_C_COMPILER_ID=clang and
MSVC get's defined since clang-cl is basically a MSVC
emulator. So guarding like we do in this patch seems logical.
@bagder bagder added the cmake label Nov 10, 2020
Copy link
Contributor

@jzakrzewski jzakrzewski left a comment

LGTM

@bagder
Copy link
Member

@bagder bagder commented Nov 10, 2020

Thanks!

@bagder bagder closed this in fd5f35e Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.