Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle linker flags for static libs #6195

Closed
wants to merge 1 commit into from

Conversation

@tru
Copy link
Contributor

@tru tru commented Nov 10, 2020

Curl CMake was setting the the EXE flags for static libraries which made the /manifest:no flag ended up when linking the static library, which is not a valid flag for lib.exe or llvm-lib.exe and caused llvm-lib to exit with an error.

The better way to handle this is to make sure that we pass the correct linker flags to CMAKE_STATIC_LINKER_FLAGS instead.

Curl CMake was setting the the EXE flags for static libraries
which made the /manifest:no flag ended up when linking the
static library, which is not a valid flag for lib.exe or llvm-lib.exe
and caused llvm-lib to exit with an error.

The better way to handle this is to make sure that we pass the correct
linker flags to CMAKE_STATIC_LINKER_FLAGS instead.
@bagder bagder added the cmake label Nov 10, 2020
Copy link
Contributor

@jzakrzewski jzakrzewski left a comment

LGTM

@bagder
Copy link
Member

@bagder bagder commented Nov 10, 2020

thanks!

@bagder bagder closed this in 760e854 Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.