asyn: use 'struct thread_data *' instead of 'void *' #6239
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To reduce use of types that can't be checked at compile time. Also removes several typecasts. ... and rename the struct field from 'os_specific' to 'tdata'.
jay
approved these changes
Nov 23, 2020
| @@ -519,7 +519,7 @@ struct Curl_async { | |||
| int port; | |||
| struct Curl_dns_entry *dns; | |||
| int status; /* if done is TRUE, this is the status from the callback */ | |||
| void *os_specific; /* 'struct thread_data' for Windows */ | |||
| struct thread_data *tdata; /* 'struct thread_data' for Windows */ | |||
There was a problem hiding this comment.
Suggested change
| struct thread_data *tdata; /* 'struct thread_data' for Windows */ | |
| struct thread_data *tdata; |
outdated comment, otherwise looks ok
There was a problem hiding this comment.
Ack, will amend before merge!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reduce use of types that can't be checked at compile time. Also
removes several typecasts.
... and rename the struct field from 'os_specific' to 'tdata'.