ngtcp2: minor adjustments to make it work with public servers #6250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This field needs to be wide enough to hold sockaddr_in6 when connecting via IPv6. Otherwise, ngtcp2_conn_read_pkt will drop the packets because of the address mismatch: I00000022 [...] con ignore packet from unknown path We can safely assume that struct sockaddr_storage is available, as it is used in the public interface of ngtcp2.
bagder
approved these changes
Nov 26, 2020
|
Thanks! |
bagder
pushed a commit
that referenced
this pull request
Nov 26, 2020
bagder
pushed a commit
that referenced
this pull request
Nov 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I tried to use HTTP/3 support against some public servers and ran into a similar issue as #6027, which was indeed a version mismatch. Given most of the public servers are still at draft-29, I suggest advertising the minimal QUIC version supported by ngtcp2. This PR also fixes an issue in path validation, where local address is clobbered when connecting via IPv6.