Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ngtcp2: minor adjustments to make it work with public servers #6250

Closed
wants to merge 3 commits into from

Conversation

@ueno
Copy link
Contributor

@ueno ueno commented Nov 26, 2020

I tried to use HTTP/3 support against some public servers and ran into a similar issue as #6027, which was indeed a version mismatch. Given most of the public servers are still at draft-29, I suggest advertising the minimal QUIC version supported by ngtcp2. This PR also fixes an issue in path validation, where local address is clobbered when connecting via IPv6.

ueno added 3 commits Nov 26, 2020
This field needs to be wide enough to hold sockaddr_in6 when
connecting via IPv6.  Otherwise, ngtcp2_conn_read_pkt will drop the
packets because of the address mismatch:
  I00000022 [...] con ignore packet from unknown path

We can safely assume that struct sockaddr_storage is available, as it
is used in the public interface of ngtcp2.
@bagder
bagder approved these changes Nov 26, 2020
@bagder
Copy link
Member

@bagder bagder commented Nov 26, 2020

Thanks!

@bagder bagder closed this in 0cbd5d5 Nov 26, 2020
bagder added a commit that referenced this pull request Nov 26, 2020
bagder added a commit that referenced this pull request Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants