-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
libcurl: expose CMAKE_OPENSSL_AUTO_LOAD_CONFIG #6435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Do I need to do something about the one failing check? Is it a false positive? |
No, that's a flaky test causing a false positive. Your PR looks fine! |
Thanks! |
We have this unfortunate set of options beginning with "CMAKE_". GUI tools use those prefixes to group options together, so it's kinda namespacing which we're hijacking :/. I'd prefer we wouldn't add more of those. Could you come up with a name that does not begin with "CMAKE_"? |
Sure, I can change it to whatever you find more suitable. I've just been following what appeared to be the current convention. I guess the simplest change would be to simply remove the |
I've updated the pull request. Please take a look when you've got time and let me know if there's anything else I can do. Thanks! |
Ping? :) |
Sorry - I'm quite busy those days. In case you were wondering what I mean by grouping, this is what CMake GUI does: |
Thanks! Yes, I did understand your grouping concern. I'm perfectly happy to name the cmake Looking at the current CMakeLists.txt file I see several patterns emerging:
To me, the Unfortunately I don't know what else to suggest naming-wise. I'll wait for @jay's suggestion, as requested. |
Also, if we don't keep the |
Yes, those are exactly the things I've been thinking about and haven't come up with a good answer. As this is not only strictly CMake question, maybe also @bagder could throw in something. Some general thoughts? What about cleaning this mess up? Would that be considered breaking backwards compatibility? |
I'm sorry to say I don't have a strong opinion about cmake namespacing. If we change the existing option names now we're going to break builds. As I mentioned in a recent PR I thought USE_xxx was for libraries and CURL_xxx was for protocols. If you run
What about CURL_DISABLE_OPENSSL_AUTO_LOAD_CONFIG:BOOL=OFF (which is also the name of the symbol) ? |
This does for cmake builds what --disable-openssl-auto-load-config does for autoconf builds.
Changed to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem, all's well that ends well. 👍 |
Thanks |
This does for cmake builds what --enable-openssl-auto-load-config
does for autoconf builds.