runtests: preprocess the DISABLED file#6477
Closed
bagder wants to merge 2 commits into
Closed
Conversation
... and remove all other variable substitutions as they're now done once and for all in the preprocessor.
... with this function provided, we can disable tests for specific environments and setups directly within this file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this functionality added, we can put platform-specific disables into the file with conditionals and thus move them from the different CI-specific control scripts into a single place. For better overview and to make sure they affect everyone who runs the tests on the affected platforms and build combinations!