Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get --request-target working with HTTP proxy #6490

Closed
wants to merge 2 commits into from

Conversation

@fabiankeil
Copy link
Contributor

@fabiankeil fabiankeil commented Jan 19, 2021

Currently the --request-target is ignored when an HTTP proxy is being used.

This PR adds a test for this and includes a potential fix.

bagder
bagder approved these changes Jan 19, 2021
@bagder
Copy link
Member

@bagder bagder commented Jan 19, 2021

This fails in the disabled-proxy build because the test doesn't require proxy support within the <client> section:

<features>
proxy
</features>

@fabiankeil fabiankeil force-pushed the proxy-request-target branch from 90af05a to eb292a7 Jan 20, 2021
@fabiankeil
Copy link
Contributor Author

@fabiankeil fabiankeil commented Jan 20, 2021

Thanks for the review. I've added the section.

@bagder bagder closed this in 0015e06 Jan 20, 2021
@bagder
Copy link
Member

@bagder bagder commented Jan 20, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants