Get --request-target working with HTTP proxy#6490
Closed
fabiankeil wants to merge 2 commits into
Closed
Conversation
bagder
approved these changes
Jan 19, 2021
Member
|
This fails in the disabled-proxy build because the test doesn't require proxy support within the |
fabiankeil
force-pushed
the
proxy-request-target
branch
from
90af05a to
eb292a7
Compare
Contributor
Author
|
Thanks for the review. I've added the section. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the --request-target is ignored when an HTTP proxy is being used.
This PR adds a test for this and includes a potential fix.