connectdata struct reorgs #6534
Closed
+66
−67
Conversation
... as the numerical IP address is already stored and kept in 'primary_ip'.
... and use 'int' for ports. We don't use 'unsigned short' since -1 is still often used internally to signify "unknown value" and 0 - 65535 are all valid port numbers.
As the info is already stored in the transfer handle anyway, there's no need to carry around a duplicate buffer for the life time of the handle.
... and rely only on the value already set in Curl_easy.
To optimize storage slightly.
bagder
added a commit
that referenced
this issue
Jan 27, 2021
... and use 'int' for ports. We don't use 'unsigned short' since -1 is still often used internally to signify "unknown value" and 0 - 65535 are all valid port numbers. Closes #6534
bagder
added a commit
that referenced
this issue
Jan 27, 2021
As the info is already stored in the transfer handle anyway, there's no need to carry around a duplicate buffer for the life-time of the handle. Closes #6534
bagder
added a commit
that referenced
this issue
Jan 27, 2021
... and rely only on the value already set in Curl_easy. Closes #6534
bagder
added a commit
that referenced
this issue
Jan 27, 2021
bagder
added a commit
that referenced
this issue
Jan 27, 2021
To optimize storage slightly. Closes #6534
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Removes duplicate struct entries, changes struct field sizes and reorder them a bit. Cuts off 136 bytes from the
connectdatastruct with no loss of functionality and no added size in other structs.From 1832 bytes with 5 "holes" in my build before this PR. At 1696 bytes with one hole afterward.
The text was updated successfully, but these errors were encountered: