-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
TCP Fast Open support #660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Added documentation. |
|
Lovely! But where does the |
|
Looks like it's defined in |
|
Hmm, the Travis test failure seems unrelated. |
|
Rebased and pushed. Looks like everything's ok now :) |
|
I guess maybe it's too early, but as far as I'm concerned this is ready to be merged. I'll open a different PR for the Linux support if this gets merged before I can push the patch. |
|
I wouldn't mind having the Linux version in its own separate PR anyway so I don't think they need to be very tightly associated. I just feel that by waiting for the Linux version too before merging we can get them in for the same release (probably the next one then since we close the feature window in two days) and get a bigger momentum for users to actually try it out and get it used. |
|
Hey @ghedo, do you think we're ripe to merge this? |
|
I rebased on master and finally added support for Linux, though it seems that newer Linux versions (on the client side) are not compatible with older versions (on the server side) so keep that in mind while testing. |
|
One thing missing from the Linux support is making this work with SSL, but I'll leave that for another time. |
|
@bagder ping? |
|
Not forgotten, I promise! Just a busy week here in my end. |
|
Can you please rebase this? |
|
Done. |
|
Rebased again (there was a conflict in |
|
thanks a lot! |
This adds support for TFO (RFC7413) to libcurl and curl. Right now it only supports recent OS X versions (>= El Capitan), but I plan to add Linux support as well (it's a bit trickier though). Still need to write documentation as well.