Remove 'conn->data' completely - #6608
Closed
bagder wants to merge 2 commits into
Closed
Conversation
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
The Curl_easy pointer struct entry in connectdata is now gone.
bagder
force-pushed
the
bagder/conn-data-is-gone
branch
from
February 15, 2021 15:36
2c28296 to
5c4d678
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This complete removes the
struct Curl_easy *datastruct member from theconnectdatastruct.This PR contains the #6520 and #6522 commits at this point but they will be merged individually before this, so I'll remove them when that happens.Wiki page about it: https://github.com/curl/curl/wiki/conn.data-considered-bad