http: do not add a referrer header with empty value #6610
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That should not be the case but this change blocks --referer "" though I can't imagine why one would do that. |
|
Yes, it will block passing an empty referrer header. On the receiving end a non-existing header should be equivalent to one that has an empty value. Unless I'm missing something. This change will also make |
Previously an empty 'Referer:' header was added to the HTTP request when passing `--referer ';auto'` or `--referer ''` on the command-line. This patch makes `--referer` work like `--header 'Referer:'` and will only add the header if it has a non-zero length value. Closes #xxxx
vszakats
changed the title
|
Updated to clear a previously set referrer when an empty value is passed, restoring original behaviour in this respect. |
jay
approved these changes
Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously an empty 'Referer:' header was added to the HTTP request when passing
--referer ';auto'or--referer ''on the command-line. This patch makes--refererwork like--header 'Referer:'and will only add the header if it has a non-zero length value.