Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi: rename the multi transfer states #6612

Closed
wants to merge 1 commit into from
Closed

Conversation

@bagder
Copy link
Member

@bagder bagder commented Feb 16, 2021

While working on documenting the states it dawned on me that step one is to use better descriptive names on the states. This also changes prefix on them to make them shorter in the source (from CURLM_STATE_ to MSTATE_).

New name old name
INIT INIT
PENDING CONNECT_PEND
CONNECT CONNECT
RESOLVING WAITRESOLVE
CONNECTING WAITCONNECT
TUNNELING WAITPROXYCONNECT
PROTOCONNECT SENDPROTOCONNECT
PROTOCONNECTING PROTOCONNECT
DO DO
DOING DOING
DOING_MORE DO_MORE
DID DO_DONE
PERFORMING PERFORM
RATELIMITING TOOFAST
DONE DONE
COMPLETED COMPLETED
MSGSENT MSGSENT

The general rule is that *ING states will remain in there until a condition is met, while the others are just transitional.

@bagder bagder added the tidy-up label Feb 16, 2021
@bagder

This comment has been hidden.

@bagder

This comment has been hidden.

While working on documenting the states it dawned on me that step one is
to use better descriptive names on the states. This also changes prefix
on them to generally make them shorter in the source.

State names NOT ending with *ing are transitional ones.
@bagder bagder force-pushed the bagder/multi-state-names branch from a0b45d2 to d12b98d Feb 16, 2021
@bagder
Copy link
Member Author

@bagder bagder commented Feb 16, 2021

Working draft state diagram
curl-transfer-state-machine-v5

@bagder bagder closed this in 94719e7 Feb 16, 2021
@bagder bagder deleted the bagder/multi-state-names branch Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant