multi: rename the multi transfer states - #6612
Closed
bagder wants to merge 1 commit into
Closed
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
While working on documenting the states it dawned on me that step one is to use better descriptive names on the states. This also changes prefix on them to generally make them shorter in the source. State names NOT ending with *ing are transitional ones.
bagder
force-pushed
the
bagder/multi-state-names
branch
from
February 16, 2021 10:17
a0b45d2 to
d12b98d
Compare
Member
Author
|
Working draft state diagram |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on documenting the states it dawned on me that step one is to use better descriptive names on the states. This also changes prefix on them to make them shorter in the source (from
CURLM_STATE_toMSTATE_).The general rule is that
*INGstates will remain in there until a condition is met, while the others are just transitional.