Skip to content

mingw: enable using strcasecmp() - #6644

Closed
vszakats wants to merge 1 commit into
curl:masterfrom
vszakats:mingw-strcasecmp
Closed

mingw: enable using strcasecmp()#6644
vszakats wants to merge 1 commit into
curl:masterfrom
vszakats:mingw-strcasecmp

Conversation

@vszakats

@vszakats vszakats commented Feb 22, 2021

Copy link
Copy Markdown
Member

This will make the Features: list sorted case-insensitively, bringing output in-line with *nix builds.

@vszakats vszakats added the Windows Windows-specific label Feb 22, 2021
@jay

jay commented Feb 23, 2021

Copy link
Copy Markdown
Member

You could get rid of HAVE_STRCASECMP as well and replace strcasecmp with curl_strequal

@bagder

bagder commented Feb 23, 2021

Copy link
Copy Markdown
Member

The only current use of strcasecmp() is src/tool_help.c which uses the function as input to qsort(). This means curl_strequal() is not a simple drop-in replacement as they differ in return codes, in particular when there's not a match.

@jay

jay commented Feb 23, 2021

Copy link
Copy Markdown
Member

This means curl_strequal() is not a simple drop-in replacement as they differ in return codes, in particular when there's not a match.

ah didn't realize that.. disregard then

@vszakats vszakats closed this in fb98a43 Feb 23, 2021
@vszakats
vszakats deleted the mingw-strcasecmp branch February 23, 2021 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Windows Windows-specific

Development

Successfully merging this pull request may close these issues.

3 participants