cookies: Support multiple -b parameters - #6649
Closed
danielgustafsson wants to merge 1 commit into
Closed
Conversation
Previously only a single -b cookie parameter was supported with the last one winning. This adds support for supplying multiple -b params to have them serialized semicolon separated. Both cookiefiles and cookies can be entered multiple times. Closes #xxxx
bagder
reviewed
Feb 24, 2021
Member
Author
|
Question is, do we want |
Member
|
I think it makes sense and it probably makes the option easier to document/use... |
danielgustafsson
force-pushed
the
dg-multiple-cookies
branch
from
February 24, 2021 12:48
5124e41 to
4bb4049
Compare
Member
Author
|
Pushed a rebase with support for multiple cookiefiles and some test updates. |
Member
Author
|
The single buildfailure in Appveyor is test 1509 which isn't related to cookies at all, likely a flake. |
bagder
approved these changes
Feb 25, 2021
bagder
left a comment
bagder
left a comment
Member
There was a problem hiding this comment.
I think it could be worth adding something to docs/cmdline/cookie.d too about this, but other than that I think this looks fine!
Member
Author
|
On 25 Feb 2021, at 16:15, Daniel Stenberg ***@***.***> wrote:
@bagder approved this pull request.
I think it could be worth adding something to docs/cmdline/cookie.d too about this, but other than that I think this looks fine!
Good point, I'll add a small note there before pushing to master.
|
Member
|
It currently says "If this option is used several times, the last one will be used." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously only a single -b cookie parameter was supported with the last one winning. This adds support for supplying multiple -b params to have them serialized semicolon separated.
This is bit of a draft PR so far which lacks tests.