Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/vtls/openssl: remove get_ssl_version_txt in favor of SSL_get_version #6665

Closed
wants to merge 1 commit into from

Conversation

@jpmenil
Copy link
Contributor

@jpmenil jpmenil commented Feb 26, 2021

We can get rid of few lines of code, since SSL_get_version achieve the exact same thing

Signed-off-by: Jean-Philippe Menil jpmenil@gmail.com

We can get rid of few lines of code, since SSL_get_version achieve the exact same thing

Signed-off-by: Jean-Philippe Menil <jpmenil@gmail.com>
@@ -3386,7 +3357,7 @@ static CURLcode ossl_connect_step2(struct Curl_easy *data,

/* Informational message */
infof(data, "SSL connection using %s / %s\n",
get_ssl_version_txt(backend->handle),
SSL_get_version(backend->handle),

This comment has been minimized.

@danielgustafsson

danielgustafsson Feb 26, 2021
Member

OpenSSL supports this all the way back to 0.9.8 so this seems like a neat simplification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants