Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix memory leak in curl_sasl.c #667
If any parameter in a HTTP DIGEST challenge message is present multiple
Server answer to reproduce the leak is:
Two blocks will be "definitely lost" in valgrind: one for the first algorithm and one for the first nonce.
I'm ok with this but I think that's a really weird thing to see especially if they have the same algorithm. What server are you seeing that on? It says this for algorithm in RFC 2617:
I would expect a different Digest challenge is somehow separated though and prefixed with 'Digest'. Even if it is it would appear we ignore duplicate digest messages see https://github.com/curl/curl/blob/curl-7_47_1/lib/http.c#L850-L872