This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why do you want to hardcode the use of cygpath? I am running the testsuite, including OpenSSH tests using CopSSH, using just Msys2 and MinGW-w64 from an Msys2 shell just fine. Even Msys and MinGW32 works just fine. Please see here.
The truth is opposite. Currently path is hardcoded in testsuite as testsuite depends on that any Msys path must starts with "/cygdrive".
The content of /etc/fstab on freshly installed Msys2:
# For a description of the file format, see the Users Guide
# DO NOT REMOVE NEXT LINE. It remove cygdrive prefix from path
none / cygdrive binary,posix=0,noacl,user 0 0
Moreover, for example, I mount my development directory as /dvlp root path. More variants is possible.
Currently testsuite can't run on freshly installed Msys2/MinGW64 even with default settings. cygpath is core Cygwin/Msys program, hardly you can find Msys with default ln, ls, rm, tr, but without cygpath.
I can confirm msys2 /cygdrive/ paths don't work but I can also confirm original mingw32 (mine at least) doesn't come with a cygpath utility. We probably could use a function to transform the path depending on what's available.
It's not abandoned. I had to learn Perl to write module which is flexible enough to handle all Msys/Cygwin configurations. Will publish it soon, but I can't reopen this PR - only repo owners can do this.
@Karlson2k I'm curious about the test on 'MSWin32' in runtests.pl. This includes e.g. Strawberry Perl, but the .pl script(s) depends on a working fork which to me seems only Cygwin32/64 Perl has. Have you tried other Perls on Windows? Since I'm a Perl n00b myself, I wonder how runtest.pl could be made to work with Strawberry Perl on Windows.
@gvanem, Strawberry Perl as well as ActivePerl have fork emulation on Windows: http://perldoc.perl.org/perlfork.html
But testsuite depends on other GNU tools and process paths in Unix-style. So test can be run only on Msys/Cygwin environment with Perl build for Msys/Cygwin. But I think that support for native Windows Perl can be added without massive overhauling.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.