libssh: get rid of PATH_MAX #6829
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvengler
force-pushed
the
2021-04-libssh-no-path-max
branch
from
67b700e to
9a07794
Compare
jay
reviewed
Apr 1, 2021
cvengler
added a commit
to cvengler/curl
that referenced
this pull request
Apr 1, 2021
This removes the last occurrence of PATH_MAX inside our libssh implementation by calculating the path length from the string length of the two components. Closes curl#6829
cvengler
force-pushed
the
2021-04-libssh-no-path-max
branch
from
9a07794 to
bfff6dc
Compare
bagder
approved these changes
Apr 1, 2021
Not yet, I will have a deeper look at it this evening. So far I only focused on getting rid of PATH_MAX due to various reasons |
This removes the last occurrence of PATH_MAX inside our libssh implementation by calculating the path length from the string length of the two components. Closes curl#6829
cvengler
force-pushed
the
2021-04-libssh-no-path-max
branch
from
bfff6dc to
e5e5b3c
Compare
|
Hey, sorry that Friday evening evolved into Sunday noon. I adjusted the patch to use aprintf(). I think this is ready to be merged. |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the last occurrence of PATH_MAX inside our libssh
implementation by calculating the path length from the string length of
the two components.