checksrc: complain on == NULL or != 0 checks in conditions #6912
Merged
checksrc: complain on == NULL or != 0 checks in conditions #6912
Conversation
bagder
force-pushed
the
bagder/checksrc-conditions
branch
from
553df23 to
da38cd0
Compare
binSaed
approved these changes
Apr 21, 2021
bagder
force-pushed
the
bagder/checksrc-conditions
branch
from
da38cd0 to
52fab72
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
makes these boolean conditional checks consistent throughout the code base. Use
if(!var)to check for== NULLandif(var)to check for!= 0.