makefile.m32: add missing libs for -winssl option #693
Conversation
|
By analyzing the blame information on this pull request, we identified @gknauf, @captain-caveman2k and @bagder to be potential reviewers |
* generate .def file and use it when building the .dll, making sure to limit the list of exported functions to libcurl ones. This should fix the bloated .dll and implib. * allow to build without nghttp2 * build with WinSSL if no other SSL backend is found * document the reason for -DCURL_LIBSTATIC option * fix building with WinSSL by using two local curl patches curl patches were submitted upstream as: curl/curl#692 curl/curl#693
* generate .def file and use it when building the .dll, making sure to limit the list of exported functions to libcurl ones. This should fix the bloated .dll and implib. * allow to build without nghttp2 * build with WinSSL if no other SSL backend is found * document the reason for -DCURL_LIBSTATIC option * fix building with WinSSL by using two local curl patches curl patches were submitted upstream as: curl/curl#692 curl/curl#693
Is this for a static build and are you sure the dependency on bcrypt is for WinSSL and not libssh2? You may need to wrap this in !DYN wherever it goes |
|
Good points. I'll make tests and update accordingly. (Sorry for the sloppiness.) |
|
Both of them is required for libssh2 only: Tested with libssh2: Patch updated. (There are some libssh2 warnings which are valid and need to fixed not just for WinSSL, but for f.e. OpenSSL 1.1.0 as well) |
|
Hold on for an hour. I'll recheck the .dll part, too. |
|
There's no rush there's like 3 weeks until release, just update the thread when you have something ready and someone will take a look |
|
Final candidate committed, with a simplification and tested with both .exe and .dll. With libssh2: https://ci.appveyor.com/project/vszakats/harbour-deps/build/1.0.715 |
|
Thanks, landed in 6c7a5b9. |
Required for a successful link. Similar logic is already present in
libssh2.