Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sasl: binary messages #6930

Closed
wants to merge 1 commit into from
Closed

sasl: binary messages #6930

wants to merge 1 commit into from

Conversation

@monnerat
Copy link
Contributor

@monnerat monnerat commented Apr 22, 2021

Capabilities of sasl module are extended to exchange messages in binary as an alternative to base64.

If http authentication flags have been set, those are used as sasl default preferred mechanisms.

lib/curl_sasl.c Outdated
@@ -58,7 +58,7 @@
static const struct {
const char *name; /* Name */
size_t len; /* Name length */
unsigned int bit; /* Flag bit */
unsigned long bit; /* Flag bit */
Copy link
Member

@bagder bagder Apr 26, 2021

Why this change? We cannot assume that a long is larger than 32 bit anyway... and if you want to store 32 bit, why use 64 bit on some platforms?

Copy link
Contributor Author

@monnerat monnerat Apr 26, 2021

HTTP authentication flags are already defined as unsigned long: although not yet related, the idea behind this change is to ease a possible future unification of sasl and http authentication flags.
This is the only reason. But perhaps the change would have to be done the other way on http side, which is not the target of my current work.
I can drop it for now, if you prefer.

lib/curl_sasl.h Outdated Show resolved Hide resolved
@monnerat
Copy link
Contributor Author

@monnerat monnerat commented Aug 16, 2021

IMHO, this is ready for review/pull.

@monnerat monnerat force-pushed the sasl branch 2 times, most recently from c95a50f to ed5f3c0 Sep 3, 2021
@monnerat monnerat force-pushed the sasl branch 2 times, most recently from 7c8ed33 to 0c01ed4 Sep 15, 2021
@monnerat monnerat force-pushed the sasl branch 4 times, most recently from a777b3f to 5222519 Sep 28, 2021
@monnerat
Copy link
Contributor Author

@monnerat monnerat commented Oct 2, 2021

@bagder : Please can you look at this while the feature window is open? Having it unpushed blocks my work on openldap. Thanks.

@bagder
Copy link
Member

@bagder bagder commented Oct 2, 2021

@monnerat for the future, please request a review of the PR. It's an excellent way to signal that you're ready/done (and a good way for me to spot/filter such PRs).

lib/pop3.c Outdated Show resolved Hide resolved
lib/imap.c Outdated Show resolved Hide resolved
lib/smtp.c Outdated Show resolved Hide resolved
@monnerat
Copy link
Contributor Author

@monnerat monnerat commented Oct 2, 2021

for the future, please request a review of the PR. It's an excellent way to signal that you're ready/done (and a good way for me to spot/filter such PRs).

Sorry for using a comment for that, but the "request review" icon is sometimes missing. Github bug ?
Anyway I'll use it when present.

Capabilities of sasl module are extended to exchange messages in binary
as an alternative to base64.

If http authentication flags have been set, those are used as sasl
default preferred mechanisms.
bagder
bagder approved these changes Oct 2, 2021
@bagder
Copy link
Member

@bagder bagder commented Oct 2, 2021

Thanks!

@bagder bagder closed this in 3e2c1dc Oct 2, 2021
@monnerat
Copy link
Contributor Author

@monnerat monnerat commented Oct 2, 2021

Thanks to you for pulling.

@monnerat monnerat deleted the sasl branch Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants