libcurl-security.3: don't try to filter IPv4 hosts based on the URL#6942
Closed
libcurl-security.3: don't try to filter IPv4 hosts based on the URL#6942
Conversation
Contributor
|
Doesn't curl_url canonicalize the address when given CURLU_URLDECODE? I would
expect detecting a literal IPv4 address should be pretty reliable using that.
|
Member
Author
|
Yes, the libcurl URL API is now a good way to normalize ipv4 numerical URLs too, but that would require that users let libcurl do that before comparing addresses and it seemed like a much harder thing to explain in the document... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.