Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid static for sock_opt in nss_set_blocking #6945

Closed
wants to merge 1 commit into from
Closed

Conversation

@piru
Copy link

@piru piru commented Apr 23, 2021

using static data can lead to confusion of the blocking status between simultaneous calls

@bagder
Copy link
Member

@bagder bagder commented Apr 23, 2021

The 2c6a728 commit seems unrelated though, right?

Loading

@piru
Copy link
Author

@piru piru commented Apr 23, 2021

The 2c6a728 commit seems unrelated though, right?

Oh yeah. At times I hate my inability with git...

Loading

kdudka
kdudka approved these changes Apr 25, 2021
Copy link
Collaborator

@kdudka kdudka left a comment

Good catch. This problem was introduced in commit 8fa5409 which made the flag parameterized. The fix looks appropriate. Thanks!

Loading

bagder
bagder approved these changes Apr 26, 2021
Copy link
Member

@bagder bagder left a comment

Any reason this is still marked "draft" @piru ?

Loading

@piru piru marked this pull request as ready for review Apr 26, 2021
@bagder bagder closed this in f2e1163 Apr 26, 2021
@bagder
Copy link
Member

@bagder bagder commented Apr 26, 2021

Thanks!

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants