add memory management information for curl_url_set #6953
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wording taken from man page for CURLOPT_URL <https://github.com/curl/curl/blob/04488851e291ea0fc3f32e87ea637afcf1c2ca28/docs/libcurl/opts/CURLOPT_URL.3#L67-L68> As far as I can see, the URL part is either malloc'ed before due to encoding <https://github.com/curl/curl/blob/04488851e291ea0fc3f32e87ea637afcf1c2ca28/lib/urlapi.c#L1512> or it is strdup'ed <https://github.com/curl/curl/blob/04488851e291ea0fc3f32e87ea637afcf1c2ca28/lib/urlapi.c#L1516>.
bagder
approved these changes
Apr 25, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
It would be nice to know how to manage the memory of a newly set URL (part) from the documentation. From reading the respective source file
lib/urlapi.c, I gather that the changes represent that accurately: The string that ends up being written to the URL struct is eithermalloc'ed before either due to encoding or appending a query, or it isstrdup'ed.I made the wording similar to the man page for
CURLOPT_URL:curl/docs/libcurl/opts/CURLOPT_URL.3
Lines 67 to 68 in 0448885