Skip to content

Use ALPN in rustls - #6960

Closed
jsha wants to merge 2 commits into
curl:masterfrom
jsha:rustls-alpn
Closed

jsha wants to merge 2 commits into
curl:masterfrom
jsha:rustls-alpn

Conversation

@jsha

@jsha jsha commented Apr 25, 2021 •

Copy link
Copy Markdown
Contributor

No description provided.

@jsha
jsha marked this pull request as draft April 25, 2021 02:02
Comment thread lib/vtls/rustls.c Outdated
@bagder

bagder commented Apr 29, 2021

Copy link
Copy Markdown
Member

The travis build is unhappy:

vtls/rustls.c: In function ‘cr_init_backend’:
vtls/rustls.c:337:3: error: implicit declaration of function ‘rustls_client_config_builder_set_protocols’; did you mean ‘rustls_server_config_builder_set_protocols’? [-Wimplicit-function-declaration]
   rustls_client_config_builder_set_protocols(config_builder, alpn, 2);
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   rustls_server_config_builder_set_protocols
vtls/rustls.c:337:3: error: nested extern declaration of ‘rustls_client_config_builder_set_protocols’ [-Werror=nested-externs]
vtls/rustls.c: In function ‘cr_set_negotiated_alpn’:
vtls/rustls.c:393:3: error: implicit declaration of function ‘rustls_client_session_get_alpn_protocol’; did you mean ‘rustls_client_session_read_tls’? [-Wimplicit-function-declaration]
   rustls_client_session_get_alpn_protocol(session, &protocol, &len);
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   rustls_client_session_read_tls
vtls/rustls.c:393:3: error: nested extern declaration of ‘rustls_client_session_get_alpn_protocol’ [-Werror=nested-externs]
cc1: all warnings being treated as errors

@bagder

bagder commented Apr 29, 2021

Copy link
Copy Markdown
Member

Ah, I guess that is because of the waiting PRs mentioned here already...

@jsha

jsha commented Apr 30, 2021

Copy link
Copy Markdown
Contributor Author

Oops, sorry about that. The crustls PR was merged, but I needed to tag a new release (0.5.0). I've done that now and updated .travis.yml and docs/RUSTLS.md to match.

@jsha
jsha marked this pull request as ready for review April 30, 2021 00:26
@bagder bagder closed this in 8228002 Apr 30, 2021
@bagder

bagder commented Apr 30, 2021

Copy link
Copy Markdown
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants