Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imap: display quota information #6973

Closed
wants to merge 1 commit into from
Closed

Conversation

@axmo12
Copy link
Contributor

@axmo12 axmo12 commented Apr 27, 2021

Show response to "GETQUOTAROOT INBOX" command.

Show response to "GETQUOTAROOT INBOX" command.
@bagder bagder added the IMAP label Apr 27, 2021
@bagder
Copy link
Member

@bagder bagder commented Apr 29, 2021

Can we come up with a better way for this than to just keep adding specific commands to that already overly large conditional check?

Loading

@axmo12
Copy link
Contributor Author

@axmo12 axmo12 commented May 1, 2021

Well, at some point one would need to keep track of all commands that send untagged responses.
While I do agree that this solution is everything but nice, reworking this would mean refactoring the whole imap state machine and will break a lot of things.

Loading

@bagder
Copy link
Member

@bagder bagder commented May 3, 2021

Well, at some point one would need to keep track of all commands that send untagged responses.

Must we? Can we for example perhaps instead reverse the check and just allow anything else?

While I do agree that this solution is everything but nice, reworking this would mean refactoring the whole imap state machine and will break a lot of things.

It only breaks if we don't do it correctly.

Loading

@axmo12
Copy link
Contributor Author

@axmo12 axmo12 commented Jun 5, 2021

Well, at some point one would need to keep track of all commands that send untagged responses.

Must we? Can we for example perhaps instead reverse the check and just allow anything else?

I don't see your point here. - Even if you do it in a reverse manner, one would need to have a dictionary in here with all the IMAP commands.

Loading

@danielgustafsson
Copy link
Member

@danielgustafsson danielgustafsson commented Jul 7, 2021

What do we want to do here, merge this and pursue a cleanup in a separate patchset or perform a refactoring as part of this?

Loading

@bagder
Copy link
Member

@bagder bagder commented Oct 28, 2021

Let's just merge this to at least fix @axmo12's issue. I still want it done in a better way but clearly not me nor anyone else is going to do this anytime soon.

Loading

@bagder bagder closed this in 49ab21e Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants