Fix some slightly incorrect uses of checkprefix#6993
Closed
piru wants to merge 5 commits intocurl:masterfrom
piru:master
Closed
Fix some slightly incorrect uses of checkprefix#6993piru wants to merge 5 commits intocurl:masterfrom piru:master
piru wants to merge 5 commits intocurl:masterfrom
piru:master
Conversation
added 5 commits
May 3, 2021 00:04
bagder
approved these changes
May 3, 2021
Member
|
Thanks! |
bagder
pushed a commit
that referenced
this pull request
May 3, 2021
bagder
pushed a commit
that referenced
this pull request
May 3, 2021
bagder
pushed a commit
that referenced
this pull request
May 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In various places
checkprefixfunction is used in a way that can lead to potential forward compatibility issues. As an example if new authentication method"NTLM3"would be added,checkprefix("NTLM", auth)would incorrectly match it. Now either space, null char, or comma is required after the method value.In addition fixed a bogus use of
checkprefixfunction in Kerberosname_to_levelfunction. TheCURLOPT_KRBLEVELAPI provided string was used as the prefix to check. It would kind of work if correct values were passed but would match incomplete strings as specific values. For example"c"would match toPROT_CLEAR. Usingcurl_strequalmakes more sense here.