Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some slightly incorrect uses of checkprefix #6993

Closed
wants to merge 5 commits into from
Closed

Conversation

@piru
Copy link

@piru piru commented May 2, 2021

In various places checkprefix function is used in a way that can lead to potential forward compatibility issues. As an example if new authentication method "NTLM3" would be added, checkprefix("NTLM", auth) would incorrectly match it. Now either space, null char, or comma is required after the method value.

In addition fixed a bogus use of checkprefix function in Kerberos name_to_level function. The CURLOPT_KRBLEVEL API provided string was used as the prefix to check. It would kind of work if correct values were passed but would match incomplete strings as specific values. For example "c" would match to PROT_CLEAR. Using curl_strequal makes more sense here.

@bagder
bagder approved these changes May 3, 2021
@bagder
Copy link
Member

@bagder bagder commented May 3, 2021

Thanks!

@bagder bagder closed this in b75620b May 3, 2021
bagder added a commit that referenced this pull request May 3, 2021
Closes #6993
bagder added a commit that referenced this pull request May 3, 2021
Closes #6993
bagder added a commit that referenced this pull request May 3, 2021
Closes #6993
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants