http: use calculated offsets than integer literals for HTTP header parsing#7032
Closed
starrify wants to merge 1 commit intocurl:masterfrom
Closed
http: use calculated offsets than integer literals for HTTP header parsing#7032starrify wants to merge 1 commit intocurl:masterfrom
starrify wants to merge 1 commit intocurl:masterfrom
Conversation
…rsing Assumed to be a minor coding style improvement with no behavior change. A modern compiler is expected to have the calculation optimized during compilation. It may be deemed okay even if that's not the case, since the added overhead is considered very low.
DeepCode failed to analyze this pull requestSomething went wrong despite trying multiple times, sorry about that. |
bagder
reviewed
May 8, 2021
Member
bagder
left a comment
bagder
left a comment
There was a problem hiding this comment.
Improved readability is good! 👍
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was reading some code in
lib/http.c(rather irrelevant to this PR) to understandcurl's implement when I happened to notice the offset values in integer literals (e.g.headp + 15). Therefore the motivation of this PR.Local tests on my machine (GNU/Linux x86_64 with gcc) before the change (at 1763ace):
And after the change (at 2f7b2aa):
I have got a quick look at those failed tests, which seemed unrelated to the changes here.