CMake: add CURL_ENABLE_EXPORT_TARGET option.#7060
Closed
lemourin wants to merge 1 commit intocurl:masterfrom
Closed
CMake: add CURL_ENABLE_EXPORT_TARGET option.#7060lemourin wants to merge 1 commit intocurl:masterfrom
lemourin wants to merge 1 commit intocurl:masterfrom
Conversation
install(EXPORT ...) causes trouble when embedding curl dependencies which don't provide install(EXPORT ...) targets (e.g libressl and nghttp2) with cmake's add_subdirectory.
jzakrzewski
approved these changes
May 25, 2021
Contributor
jzakrzewski
left a comment
jzakrzewski
left a comment
There was a problem hiding this comment.
I see no harm in adding this.
Member
|
Thanks! |
vszakats
added a commit
that referenced
this pull request
Nov 19, 2025
…n lib and src Based on existing code and commit history it appears `CURL_DISABLE_INSTALL` means to prevent calling `install()`; `CURL_ENABLE_EXPORT_TARGET` means to prevent calling `export()` and `install()`s with `EXPORT` in them. Fix them to also apply to the lib and src directories in that vain: - lib: honor `CURL_DISABLE_INSTALL` - src: honor `CURL_DISABLE_INSTALL` - src: honor `CURL_ENABLE_EXPORT_TARGET` https://cmake.org/cmake/help/v4.2/command/install.html https://cmake.org/cmake/help/v4.2/command/export.html - `CURL_DISABLE_INSTALL` follow-up to: aace27b #12287 - `CURL_ENABLE_EXPORT_TARGET` follow-up to: 8698825 #9638 643ec29 #7060 Closes #19144
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
install(EXPORT ...) causes trouble when embedding curl dependencies which
don't provide install(EXPORT ...) targets (e.g libressl and nghttp2) with
cmake's add_subdirectory.