urlapi: reject spaces in URLs, allow if flagbit set #7073
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagder
added
URL
libcurl API
feature-window
bagder
force-pushed
the
bagder/url_set-space
branch
from
fb5bbd6
to
0db4cc7
Compare
bagder
changed the title
bagder
added a commit
that referenced
this pull request
May 15, 2021
They were never officially allowed and slipped in only due to sloppy parsing. Spaces (ascii 32) should be correctly encoded (to %20) before being part of a URL. The new flag bit CURLU_ALLOW_SPACE when a full URL is set, makes libcurl allow spaces. Closes #7073
bagder
force-pushed
the
bagder/url_set-space
branch
from
0db4cc7
to
5c444ab
Compare
bagder
added a commit
that referenced
this pull request
May 24, 2021
They were never officially allowed and slipped in only due to sloppy parsing. Spaces (ascii 32) should be correctly encoded (to %20) before being part of a URL. The new flag bit CURLU_ALLOW_SPACE when a full URL is set, makes libcurl allow spaces. Updated test 1560 to verify. Closes #7073
bagder
force-pushed
the
bagder/url_set-space
branch
from
5c444ab
to
40658cd
Compare
cvengler
reviewed
May 30, 2021
bagder
removed
the
feature-window
They were never officially allowed and slipped in only due to sloppy parsing. Spaces (ascii 32) should be correctly encoded (to %20) before being part of a URL. The new flag bit CURLU_ALLOW_SPACE when a full URL is set, makes libcurl allow spaces. Updated test 1560 to verify. Closes #7073
bagder
force-pushed
the
bagder/url_set-space
branch
from
40658cd
to
313a9bd
Compare
|
@bagder did you intend to merge this? I notice you removed next-feature-window a while back. |
|
I did mean to do that. I've hesitated a little but I'll move forward on this again in a bit. |
ghost
mentioned this pull request
|
@bagder Maybe mark in the documentation the first version where |
spdk-bot
pushed a commit
to spdk/spdk
that referenced
this pull request
Dec 14, 2021
Latest curl versions started to treat such URLs as invalid. See: curl/curl#7073 Signed-off-by: Michal Berger <michalx.berger@intel.com> Change-Id: Ic5ab34a566f89f411ec40cbcb8de57a8d2f3ea88 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/10607 Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Reviewed-by: Maciej Wawryk <maciejx.wawryk@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
The browsers' "URL bars" don't show URLs and don't follow the URL syntax. Normally however, if you copy the data in the URL bar they tend to store that copy in the clipboard in a better URL format.
Everything is always debatable, but having the argument in an old closed pull-request is not the most suitable place for this discussion. |
keithalucas
pushed a commit
to longhorn/spdk
that referenced
this pull request
Jun 30, 2022
Latest curl versions started to treat such URLs as invalid. See: curl/curl#7073 Signed-off-by: Michal Berger <michalx.berger@intel.com> Change-Id: Ic5ab34a566f89f411ec40cbcb8de57a8d2f3ea88 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/10607 Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Reviewed-by: Maciej Wawryk <maciejx.wawryk@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They were never officially allowed and slipped in only due to sloppy
parsing. Spaces (ascii 32) should be correctly encoded (to %20) before
being part of a URL.
The new flag bit
CURLU_ALLOW_SPACEwhen a full URL is set, makes libcurl allow spaces.