Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of
curl_dogetnameinfo
was removed in 2018 (commit 0aeca41), but the declaration was still in the header. This would normally be irrelevant since it is guarded by the macroHAVE_GETNAMEINFO
which is never defined, but if curl is included by a parent cmake project that also includes c-ares,HAVE_GETNAMEINFO
will be defined and compilation will fail.The second commit removes the
getnameinfo
-related macros from the config headers, since they are unused. It does not remove them frompackages/vms/config_h.com
because I'm not familiar with VMS and can't test any changes.