/ curl Public
Remove getnameinfo remnants #7094
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
The implementation of
curl_dogetnameinfowas removed in 2018 (commit 0aeca41), but the declaration was still in the header. This would normally be irrelevant since it is guarded by the macro
HAVE_GETNAMEINFOwhich is never defined, but if curl is included by a parent cmake project that also includes c-ares,
HAVE_GETNAMEINFOwill be defined and compilation will fail.
The second commit removes the
getnameinfo-related macros from the config headers, since they are unused. It does not remove them from
packages/vms/config_h.combecause I'm not familiar with VMS and can't test any changes.