Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove getnameinfo remnants #7094

Conversation

@marc-groundctl
Copy link
Contributor

@marc-groundctl marc-groundctl commented May 18, 2021

The implementation of curl_dogetnameinfo was removed in 2018 (commit 0aeca41), but the declaration was still in the header. This would normally be irrelevant since it is guarded by the macro HAVE_GETNAMEINFO which is never defined, but if curl is included by a parent cmake project that also includes c-ares, HAVE_GETNAMEINFO will be defined and compilation will fail.

The second commit removes the getnameinfo-related macros from the config headers, since they are unused. It does not remove them from packages/vms/config_h.com because I'm not familiar with VMS and can't test any changes.

@bagder
bagder approved these changes May 18, 2021
Copy link
Member

@bagder bagder left a comment

👍

@bagder bagder closed this in 6c347d4 May 18, 2021
bagder added a commit that referenced this pull request May 18, 2021
@bagder
Copy link
Member

@bagder bagder commented May 18, 2021

Thanks!

@marc-groundctl marc-groundctl deleted the GroundControl-Solutions:remove-getnameinfo-remnants branch May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants