sectransp: EXC_BAD_ACCESS caused by non deterministic value#7126
Closed
ebeworld wants to merge 8 commits intocurl:masterfrom
ebeworld:master
Closed
sectransp: EXC_BAD_ACCESS caused by non deterministic value#7126ebeworld wants to merge 8 commits intocurl:masterfrom ebeworld:master
ebeworld wants to merge 8 commits intocurl:masterfrom
ebeworld:master
Conversation
We have following code in Curl.
...
SecCertificateCopyCommonName(cert, &common_name);
#endif
if(CFStringCompare(common_name, label_cf, 0) == kCFCompareEqualTo)
When the SecCertificateCopyCommonName function fails, it does not have to leave common_name in valid, state. So CFStringCompare is using the invalid result, hence causing EXC_BAD_ACCESS.
Fix is to check return value of the function.
EXC_BAD_ACCESS caused by non deterministic value
bagder
changed the title
bagder
reviewed
May 25, 2021
Member
|
Fixing line length
Fixing trailing whitespace
bagder
approved these changes
May 25, 2021
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have following code in Curl.
...
SecCertificateCopyCommonName(cert, &common_name);
#endif
if(CFStringCompare(common_name, label_cf, 0) == kCFCompareEqualTo)
When the SecCertificateCopyCommonName function fails, it does not have to leave common_name in valid, state. So CFStringCompare is using the invalid result, hence causing EXC_BAD_ACCESS.
Fix is to check return value of the function.