bearssl: remove incorrect const on variable that is modified #7133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hostname may be set to NULL later on in this function if it is an IP address.
Also, add comments like the other vtls backends.
|
Thanks! |
bagder
pushed a commit
that referenced
this pull request
May 26, 2021
Also, add comments like the other vtls backends. Closes #7133
bagder
pushed a commit
that referenced
this pull request
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent vtls cleanup accidentally made a variable const that was modified later on in the function, causing a build failure when BearSSL is enabled. To prevent this sort of thing in the future, I added BearSSL to the Travis configuration.
While testing the Travis build, I noticed a warning that it was missing explicit initializers for a couple
struct Curl_sslfields, so I set those to NULL.