Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bearssl: remove incorrect const on variable that is modified #7133

Closed
wants to merge 3 commits into from

Conversation

@michaelforney
Copy link
Contributor

@michaelforney michaelforney commented May 26, 2021

A recent vtls cleanup accidentally made a variable const that was modified later on in the function, causing a build failure when BearSSL is enabled. To prevent this sort of thing in the future, I added BearSSL to the Travis configuration.

While testing the Travis build, I noticed a warning that it was missing explicit initializers for a couple struct Curl_ssl fields, so I set those to NULL.

hostname may be set to NULL later on in this function if it is an
IP address.
Also, add comments like the other vtls backends.
@bagder
bagder approved these changes May 26, 2021
Copy link
Member

@bagder bagder left a comment

👍 lovely!

@bagder
Copy link
Member

@bagder bagder commented May 26, 2021

Thanks!

@bagder bagder closed this in a03ea62 May 26, 2021
bagder added a commit that referenced this pull request May 26, 2021
Also, add comments like the other vtls backends.

Closes #7133
bagder added a commit that referenced this pull request May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants