Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MQTT file size improvements #7166

Closed
wants to merge 3 commits into from
Closed

MQTT file size improvements #7166

wants to merge 3 commits into from

Conversation

@piru
Copy link

@piru piru commented Jun 1, 2021

  • detect when reported file size is obviously illegal as per MQTT Version 5.0 section "1.5.5 Variable Byte Integer"
  • return CURLE_FILESIZE_EXCEEDED when file size would exceed limit set by CURLOPT_MAXFILESIZE_LARGE (if set)
@bagder
bagder approved these changes Jun 1, 2021
Copy link
Member

@bagder bagder left a comment

Bonus points will be handed out if you also add test cases that verify...

@piru
Copy link
Author

@piru piru commented Jun 1, 2021

I think the file size check should come a bit later, I'll adjust the code a bit. I'll also look into implementing test for the bogus size being returned by the server.

…llegal size sent by the server and client --max-filesize working as expected
@piru piru force-pushed the piru:mqtt-file-size-limit branch from a8ddc3e to 192508b Jun 1, 2021
@bagder bagder closed this in 8ccf755 Jun 2, 2021
@bagder
Copy link
Member

@bagder bagder commented Jun 2, 2021

Thanks!

@piru piru deleted the piru:mqtt-file-size-limit branch Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants