Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtests: parse data/Makefile.inc instead of using make #7177

Merged
merged 1 commit into from Jun 3, 2021

Conversation

bagder
Copy link
Member

@bagder bagder commented Jun 2, 2021

The warning about missing entries in that file then doesn't require that
the Makefile has been regenerated which was confusing.

The scan for the test num is a little more error prone than before
(since now it doesn't actually verify that it is legitimate Makefile
syntax), but I think it is good enough.

@bagder bagder added the tests label Jun 2, 2021
The warning about missing entries in that file then doesn't require that
the Makefile has been regenerated which was confusing.

The scan for the test num is a little more error prone than before
(since now it doesn't actually verify that it is legitimate Makefile
syntax), but I think it is good enough.

Closes #7177
@bagder bagder force-pushed the bagder/runtests-inc-warning branch from 8a880c5 to 3c0f462 Compare Jun 2, 2021
@bagder bagder closed this in 3c0f462 Jun 3, 2021
@bagder bagder merged commit 3c0f462 into master Jun 3, 2021
55 of 57 checks passed
@bagder bagder deleted the bagder/runtests-inc-warning branch Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant