runtests: add option -u to error on server unexpectedly alive#7180
Closed
mback2k wants to merge 1 commit intocurl:masterfrom
Closed
runtests: add option -u to error on server unexpectedly alive#7180mback2k wants to merge 1 commit intocurl:masterfrom
mback2k wants to merge 1 commit intocurl:masterfrom
Conversation
mback2k
force-pushed
the
fail-unexpected-testserver-alive
branch
3 times, most recently
from
a6930d0 to
f2e60fd
Compare
mback2k
force-pushed
the
fail-unexpected-testserver-alive
branch
from
f2e60fd to
e37e3ad
Compare
mback2k
force-pushed
the
fail-unexpected-testserver-alive
branch
from
e37e3ad to
a854a9a
Compare
mback2k
force-pushed
the
fail-unexpected-testserver-alive
branch
from
a854a9a to
cd993f6
Compare
mback2k
force-pushed
the
fail-unexpected-testserver-alive
branch
from
cd993f6 to
85daa74
Compare
mback2k
force-pushed
the
fail-unexpected-testserver-alive
branch
from
85daa74 to
a3ff01c
Compare
mback2k
force-pushed
the
fail-unexpected-testserver-alive
branch
from
a3ff01c to
389edbb
Compare
mback2k
force-pushed
the
fail-unexpected-testserver-alive
branch
from
389edbb to
3b3799a
Compare
bagder
requested changes
Aug 19, 2021
Member
bagder
left a comment
bagder
left a comment
There was a problem hiding this comment.
The commit message needs an update. I suppose the reason for this option is to detect and provide a way to debug problems with killing off test servers?
Let's try to actually handle the server unexpectedly alive case by first making them visible on CI builds as failures. This is needed to detect issues with killing of the test servers completely including nested process chains with multiple PIDs per test server (including bash and perl). On Windows/cygwin platforms this is especially helpful with debugging PID mixups due to cygwin using its own PID space. Reviewed-by: Daniel Stenberg Closes curl#7180
mback2k
force-pushed
the
fail-unexpected-testserver-alive
branch
from
3b3799a to
60a6d1d
Compare
Member
Author
|
Thanks for the feedback @bagder. I just rebased and pushed an extended commit message. |
bagder
approved these changes
Sep 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's try to actually handle the server unexpectedly alive
case by first making them visible on CI builds as failures.