New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schannel: Add ALPN support #724

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@JDepooter
Contributor

JDepooter commented Mar 23, 2016

Add ALPN support for schannel. This allows cURL to negotiate
HTTP/2.0 connections when built with schannel.

This requires Visual Studio 2013 or newer.

schannel: Add ALPN support
Add ALPN support for schannel. This allows cURL to negotiate
HTTP/2.0 connections when built with schannel.

@bagder bagder closed this in f8d88a4 Mar 24, 2016

@bagder

This comment has been minimized.

Member

bagder commented Mar 24, 2016

Lovely, thanks a lot!

diegobes pushed a commit to incarose/curl that referenced this pull request Mar 25, 2016

schannel: Add ALPN support
Add ALPN support for schannel. This allows cURL to negotiate
HTTP/2.0 connections when built with schannel.

Closes curl#724

@JDepooter JDepooter deleted the JDepooter:schannel_alpn branch May 18, 2016

@webmaster128

This comment has been minimized.

Contributor

webmaster128 commented May 30, 2016

Upgrading from curl 7.48.0 to 7.49.1 (both build with MSVS 2015) using schannel causes a regression bug when run on Windows 7:

HTTP exception: "'SSL connect error' in curl::curl_easy::perform" Details: schannel: failed to retrieve ALPN result

Affected URL (GET https://www.kullo.net/download/files/windows/latest-all) is HTTP 1.1 only.

On Windows Server 2012 the issue does not exist.

Is it possible that this change is responsible?

@bagder

This comment has been minimized.

Member

bagder commented May 30, 2016

I'd suggest you post this as a new issue so that we can track it and deal with it properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment